Updating L1 Emulation to run and save Tk objects #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRS
changed the title
|
Initial test from Maria shows that the collections are being filled. So think we can go ahead with this PR |
|
Tagged as l1t-phase2-v3.4.46. |
This was referenced Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR addresses the missing Tk object collections in the CMSSW_12_5_0_pre5 RelVals. I saw that some other fixes were needed to avoid errors after adding in the objects to the EventContent. One error that came up in the FEVTDEBUGHLToutput_step was:
The class "l1t::TkJetWord" is compiled and for its data member "tkJetWord_" we do not have a dictionary for the collection "bitset<70>". Because of this, we will not be able to read or write this data member.In order to fix that I tried to adjust the TkJetWord class to be like the VertexWord class from Alexx Perloff. However the error still persisted for some reason (where it does not for VertexWord). So for now have adjusted
classes_def.xmlto avoid the error.PR validation:
Used
runTheMatrix.py -w upgrade -l 39634.0 --wm initand rantime cmsRun TTbar_14TeV_TuneCP5_2026D88PU_GenSimHLBeamSpot14.pythentime cmsRun DigiTriggerPU_2026D88PU.pyfromCMSSW_12_5_0_pre5. The objects then appear in the edmDumpEventContent. The Phase2 Menu group are also looking at the step2.root file created.